Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: metadata supports key corresponding to multiple values #2772

Conversation

ibrahimalbarghouthi
Copy link
Contributor

Adding Add/Values func for transport and metadata layers, fixed tests a… #2771

…nd included tests to new functionaltieis, updated metadata middleware to append instead of hard set of key-values
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #2772 (d43d31e) into main (f03f5f8) will decrease coverage by 0.29%.
The diff coverage is 69.49%.

❗ Current head d43d31e differs from pull request most recent head 4f808fe. Consider uploading reports for the commit 4f808fe to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
- Coverage   84.75%   84.47%   -0.29%     
==========================================
  Files          88       88              
  Lines        3891     3923      +32     
==========================================
+ Hits         3298     3314      +16     
- Misses        419      434      +15     
- Partials      174      175       +1     
Impacted Files Coverage Δ
transport/grpc/transport.go 85.71% <0.00%> (-14.29%) ⬇️
transport/http/transport.go 75.00% <0.00%> (-9.38%) ⬇️
transport/transport.go 100.00% <ø> (ø)
log/helper.go 74.57% <66.66%> (-7.06%) ⬇️
metadata/metadata.go 96.36% <87.50%> (-3.64%) ⬇️
middleware/metadata/metadata.go 92.59% <100.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tonybase
tonybase previously approved these changes Apr 8, 2023
Copy link
Member

@tonybase tonybase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase
Copy link
Member

tonybase commented Apr 8, 2023

@ibrahimalbarghouthi please fix lint

@ibrahimalbarghouthi
Copy link
Contributor Author

@tonybase Done please merge

@shenqidebaozi shenqidebaozi changed the title Adding Add/Values func for transport and metadata layers, fixed tests a… refactor: metadata supports key corresponding to multiple values Apr 10, 2023
Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi enabled auto-merge (squash) April 10, 2023 06:33
@shenqidebaozi shenqidebaozi merged commit 3958f9d into go-kratos:main Apr 10, 2023
@ibrahimalbarghouthi ibrahimalbarghouthi deleted the feat/support-multi-value-metadata branch April 10, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants