-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: metadata supports key corresponding to multiple values #2772
refactor: metadata supports key corresponding to multiple values #2772
Conversation
…nd included tests to new functionaltieis, updated metadata middleware to append instead of hard set of key-values
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2772 +/- ##
==========================================
- Coverage 84.75% 84.47% -0.29%
==========================================
Files 88 88
Lines 3891 3923 +32
==========================================
+ Hits 3298 3314 +16
- Misses 419 434 +15
- Partials 174 175 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ibrahimalbarghouthi please fix lint |
@tonybase Done please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding Add/Values func for transport and metadata layers, fixed tests a… #2771