Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apollo yaml watch #3021

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix: apollo yaml watch #3021

merged 2 commits into from
Nov 22, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Oct 11, 2023

Description (what this PR does / why we need it):

fix apollo yaml watch

Which issue(s) this PR fixes (resolves / be part of):

fixes #3020

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #3021 (ff7019d) into main (6cdd818) will not change coverage.
The diff coverage is n/a.

❗ Current head ff7019d differs from pull request most recent head fe9ace0. Consider uploading reports for the commit fe9ace0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #3021   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files          88       88           
  Lines        3986     3986           
=======================================
  Hits         3362     3362           
  Misses        448      448           
  Partials      176      176           

@Windfarer
Copy link
Member

could you add some unit test for this commit

@hoslo
Copy link
Contributor Author

hoslo commented Oct 12, 2023

could you add some unit test for this commit

ok, i added it

@hoslo hoslo force-pushed the fix/apollo_yaml_watch branch 3 times, most recently from 15b301f to edc6455 Compare October 12, 2023 05:16
@hoslo
Copy link
Contributor Author

hoslo commented Oct 26, 2023

Did anybody watch this?

@Cluas Cluas merged commit e84cdde into go-kratos:main Nov 22, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apollo settings Watch cannot hot update configuration normally
6 participants