Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polaris registry bug: nodes is empty at startup #3160

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

libi
Copy link
Contributor

@libi libi commented Jan 18, 2024

Description (what this PR does / why we need it):

北极星服务发现基本不可用,在项目初始化时如果依赖的服务节点没有变化(推送watch),那么Next()函数会阻塞,导致后启动的服务获取不到其他节点信息.

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 18, 2024
@dosubot dosubot bot added the LGTM label Jan 30, 2024
@shenqidebaozi shenqidebaozi changed the title <fix>[contrib]: fix polaris registry bug: nodes is empty at startup fix: polaris registry bug: nodes is empty at startup Jan 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a556a2b) 84.62% compared to head (134cde6) 84.72%.

❗ Current head 134cde6 differs from pull request most recent head 889ac7e. Consider uploading reports for the commit 889ac7e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3160      +/-   ##
==========================================
+ Coverage   84.62%   84.72%   +0.10%     
==========================================
  Files          88       88              
  Lines        3993     3993              
==========================================
+ Hits         3379     3383       +4     
+ Misses        440      438       -2     
+ Partials      174      172       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daemon365 daemon365 merged commit 953a331 into go-kratos:main Mar 15, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants