-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change debugger to write packet via log's Writer (#1) #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply these changes to debug.go as well as v3/debug.go in order to merge.
Ill review this weekend to get them merged then!
Thanks,
Stefan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; please update with master and we'll merge it in.
@johnweldon updated 👍 also, I've prettified commits a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thank you!
This change seems to have broken an automated install for me, the go get command now gives the following error. "go/src/github.com/go-ldap/ldap/debug.go:28:19: undefined: log.Writer" |
can you specify exactly what your |
Issue
Debugger prints debug-level messages via std
log
but prints packets viaos.Stdout
, so it makes impossible to use theOutput
from the globallog
, e.g.zap
provides single point of configuration even for the globallog
, so still could be used for libraries logging setup.Solution
Pass
log#Writer()
to theber
packet writer func.Partly resolves #164