UTF8-Patch V2 2015.09.21

[BestianCode]

Unicode patch for ldap-search. I use "unicode/utf8" library for it.

1. I copied "filter" to "xfilter"
2. First "for" cut symbols from string to "newPos" position;
3. Cut "xfilter" for one symbol (not byte) per step and append to "condition"

[liggitt]

Thanks for the PR. I think a better approach would be to switch to using http://golang.org/pkg/unicode/utf8/#DecodeRuneInString to get the "next" character in the filter, rather than using substring-based extraction

[liggitt]

Something like this, for example (consider this pseudo-code... just a sketch of an approach):

nextRune, width := utf8.DecodeRuneInString(filter[pos:])
newPos = newPos + width
switch nextRune {
case utf8.RuneError:
  return nil, 0, utf8.RuneError
case rune('('):
  packet, newPos, err = compileFilter(filter, newPos)
...
default:
  for {
    nextRune, width := utf8.DecodeRuneInString(filter[pos:])
    switch nextRune {
    case utf8.RuneError:
      return nil, 0, utf8.RuneError
    case rune(')'):
      break
    default:
      // use nextRune instead of filter[newPos+1]
    }
  }
}

[BestianCode]

Hmm... I will correct :)

[liggitt]

No problem… in the future, you can push updates to your existing branch and the pull request will update itself, no need to close and reopen another one

[BestianCode]

Ok, thank you :)