Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow using ; as RDN separator according to rfc2253 #352

Merged
merged 1 commit into from
Jan 4, 2022
Merged

allow using ; as RDN separator according to rfc2253 #352

merged 1 commit into from
Jan 4, 2022

Conversation

cpuschma
Copy link
Member

@cpuschma cpuschma commented Jan 3, 2022

Fixes #351

Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the failing legacy tests.. (not in this PR) I think we accidentally introduced code depending on new language / library features that are not available in Go 1.9

@cpuschma
Copy link
Member Author

cpuschma commented Jan 4, 2022

I agree, but the error why the Go 1.9 build fails seems to come from go-ntlmssp:

Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:37:34: req.Header.Values undefined (type http.Header has no field or method Values)
Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:63:34: res.Header.Values undefined (type http.Header has no field or method Values)
Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:78:34: res.Header.Values undefined (type http.Header has no field or method Values)
Error: ../../../go/src/github.com/Azure/go-ntlmssp/negotiator.go:115:34: res.Header.Values undefined (type http.Header has no field or method Values)
Error: Process completed with exit code 2.

Looking at their travis.yml, they only run tests against 1.10.x and the latest version of Go :/

@johnweldon johnweldon merged commit 13008e4 into go-ldap:master Jan 4, 2022
@shaiacs
Copy link

shaiacs commented Jan 25, 2022

@johnweldon any plans for a release with this fix?

@johnweldon
Copy link
Member

@johnweldon any plans for a release with this fix?

I'll try to get to this in the next few days

@shaiacs
Copy link

shaiacs commented Feb 15, 2022

@johnweldon sorry to be nagging about this, but any chance you might get around to releasing this fix?

@johnweldon
Copy link
Member

@johnweldon sorry to be nagging about this, but any chance you might get around to releasing this fix?

Done.... sorry for the delay.

@shaiacs
Copy link

shaiacs commented Feb 15, 2022

No worries. Really appreciate this and all the work you've done here.

cpuschma added a commit to clementblaise/ldap that referenced this pull request Apr 25, 2022
inv2004 pushed a commit to inv2004/ldap that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semi colon is not treated as RDN separator
3 participants