-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow using ;
as RDN separator according to rfc2253
#352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix the failing legacy tests.. (not in this PR) I think we accidentally introduced code depending on new language / library features that are not available in Go 1.9
I agree, but the error why the Go 1.9 build fails seems to come from
Looking at their travis.yml, they only run tests against 1.10.x and the latest version of Go :/ |
@johnweldon any plans for a release with this fix? |
I'll try to get to this in the next few days |
@johnweldon sorry to be nagging about this, but any chance you might get around to releasing this fix? |
Done.... sorry for the delay. |
No worries. Really appreciate this and all the work you've done here. |
Fixes #351