HTTP Header Passed to ProcessPayloadFunc #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look as soon as I can, can't promise tonight but I will try and yes v2-development should be fine |
myback
added a commit
to myback/webhooks
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the functionality to both Github and Bitbucket to pass HTTP headers from each request to the ProcessPayloadFunc. This is especially useful with Github, where headers are where the webhook ID can be found in X-GitHub-Delivery.
This works with Github. I have not tested with Bitbucket. The existing tests are passing, but no tests have been added to verify the new functionality.
I can add tests if this looks like a reasonable solution to you. My feelings won't be hurt if you beat me to it.