cffi: Let Python3 handles string as ASCII. #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
changed the title
|
@sbinet PTAL |
|
thanks. |
|
np :) |
sbinet
approved these changes
Jul 12, 2017
bind/gencffi.go
Outdated
| import cffi as _cffi_backend | ||
|
|
||
| PY3 = sys.version_info[0] == 3 |
There was a problem hiding this comment.
perhaps better to unexport it (s/PY3/_PY3/g) ?
|
Thanks for the review! Updated! |
|
closed with f5e31a2. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary patch for Python3.
We have to update it to handle string as Unicode.
For Python2, I plan to set the default encoding with Unicode.