Fixed WASM compatibility by avoiding panic due to absence of os.Executable()
#226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utable()` in "js" and "wasip1" targets.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
- Coverage 74.81% 74.79% -0.03%
==========================================
Files 78 78
Lines 12814 12818 +4
==========================================
Hits 9587 9587
- Misses 2553 2557 +4
Partials 674 674 ☔ View full report in Codecov by Sentry. |
ncw
approved these changes
Nov 22, 2023
|
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.Executable()is not implemented in "js" and "wasip1" targets in current Golang versions, so WASM builds encounterExecutable not implemented for jserrors in runtime.This fix is borrowed from Brad's tailscale/tailscale#8325 .