-
Notifications
You must be signed in to change notification settings - Fork 1
Initial release #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request implements a new Go package called "slice" that provides a wrapper for slices with various utility methods. The package includes a main slice.go file with the core functionality, test files, benchmarks, CI configurations, and supporting files for different Go versions. Architecture diagram for CI/CD pipelinegraph TD;
A[Push to main branch] -->|Triggers| B[GitHub Actions]
B --> C[Build Job]
C -->|Runs on| D[Ubuntu Latest]
C --> E[Set up Go 1.x]
C --> F[Check out code]
C --> G[Test]
C --> H[Test coverage]
C --> I[Send coverage]
B --> J[Lint Job]
J -->|Runs on| D
J --> E
J --> F
J --> K[Golangci-lint]
Class diagram for the Slice packageclassDiagram
class Slice {
+FromRaw(T[] in) Slice[T]
+Raw() T[]
+Empty() bool
+Shift() (T, bool)
+Unshift(T... v)
+Pop() (T, bool)
+Push(T... v)
+DeleteOne(int index) bool
+Delete(int index, int length) bool
+Insert(int index, T... v) bool
+Clone() Slice[T]
+Cap() int
+Len() int
+ExtendCap(int i)
+Filter(func(int, T) bool)
+Get(int index) (T, bool)
+Reverse()
+Sort(func(T, T) int)
+Shuffle(func(int) int)
}
Slice <|-- FromRaw
Slice <|-- Raw
Slice <|-- Empty
Slice <|-- Shift
Slice <|-- Unshift
Slice <|-- Pop
Slice <|-- Push
Slice <|-- DeleteOne
Slice <|-- Delete
Slice <|-- Insert
Slice <|-- Clone
Slice <|-- Cap
Slice <|-- Len
Slice <|-- ExtendCap
Slice <|-- Filter
Slice <|-- Get
Slice <|-- Reverse
Slice <|-- Sort
Slice <|-- Shuffle
note for Slice "A wrapper for slices with utility methods"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bkrukowski - I've reviewed your changes - here's some feedback:
Overall Comments:
- Excellent initial release with comprehensive features, thorough testing, and good documentation. The use of generics and attention to compatibility across Go versions is commendable.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Introduce the 'slice' package, providing a wrapper for slices with intuitive operations and comprehensive test coverage. Set up CI workflows for testing and linting.
New Features:
CI:
Tests: