Issue 96 #101
Merged
Issue 96 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the winding package for figuring out the winding order for validate
Changing out the order caused all the test to fail. This is because the test assume that the values are y-down. But the order is y-up.
Just noticed that the resolve edge is not the lastest, will have to look at this with the latest resolve edge.
Looks like I lost some of the code for resolve edge for allowing controlling of winding order. Fixed up Resolve edge to make use of the fact that things are y positive now. Resolve edge is now using winding for it winding order calculations
Added the ability to compare Geom.Lines to compare.
Added a few more logs and comments, as I try and debug things.
The validate was not always getting this correctly
Check to see if a point is on a line was not allowing a high enough precision.
There is one test that is still failing, it's the one I'm working on. And a few other to be worked on which are being skipped.
Fixed failing test case due to winding order issue.
* the mvt encoder now uses the YPositiveDown field of winding.Order * added the mvt decoder
Pull Request Test Coverage Report for Build 472
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a quite a few fixes for the triangulation code. And fixes #96