-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add extended geometry types for Point as expected by EWKB standard #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 489
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. I think we should move forward in this direction. Only thing I saw, was to keep the name of the testcase array consistent with tests. Overall this look great!
Thanks
align naming of test cases variable for point types to the rest of tests modules
23b8b48
to
7912f32
Compare
@gbroccolo I'm assuming you are going to be adding the other types to this pull request, as well. |
Which additional types are you referring to? |
Yes @gdey, I can continue to push changes to this PR. Let me change the title then (it refers just to @ARolek the additional types are the extentions for |
@gdey we could merge in the extended point types now and then @gbroccolo could work on extending the other types. Having extended point types is already a win and a logic commit. I don't want this PR to get too big or blocked by additional enhancements. Thoughts? @gbroccolo thanks again for tackling this! |
I'm good with merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following PR takes care of adding the support for the following Extended geometries for point type:
PointZ
(3D),PointM
(2D+1D),PointZM
(3D+1D),PointS
(2D + SRID info),PointZS
(3D + SRID info),PointMS
(2D+1D + SRID info),PointZMS
(3D+1D + SRID info). This is related to issue #16 . Still need to add support for all the other extended geometries (i.e. the same work needed for linestring, etc.).