Skip to content

Conversation

gbroccolo
Copy link
Collaborator

As made for Point type, the PR contains the definitions of the extended geometries for LineString type.

Here basics methods for the new types have been defined, basically to reduce the extradimensions to 2D objectsin order to be integrated with the rest of the repo; e.g. LineStringZMS type is the most complete one, defining a linestring of 3+1D points in a given reference), and there's a method which reduces it to a LineStringZM which can be reduced as well to a simple LineString.

@coveralls
Copy link

coveralls commented Jul 2, 2020

Pull Request Test Coverage Report for Build 492

  • 79 of 121 (65.29%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 55.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
line_stringms.go 8 11 72.73%
line_strings.go 8 11 72.73%
line_stringzms.go 8 11 72.73%
line_stringzs.go 8 11 72.73%
line_stringm.go 7 17 41.18%
line_stringz.go 7 17 41.18%
line_stringzm.go 7 17 41.18%
Totals Coverage Status
Change from base Build 490: 0.003%
Covered Lines: 6307
Relevant Lines: 11371

💛 - Coveralls

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you run go fmt on this.

Thank you.

@gbroccolo gbroccolo force-pushed the add-extended-line-strings branch from 60b4788 to 7c69e8a Compare July 11, 2020 11:37
@gbroccolo gbroccolo requested a review from gdey July 11, 2020 11:37
@gbroccolo
Copy link
Collaborator Author

LGTM, but could you run go fmt on this.

Thank you.

Hi @gdey I formatted the code with go fmt, it also fixed the code of the previous PR for point type.

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdey gdey merged commit aca8e22 into go-spatial:master Jul 13, 2020
@gbroccolo gbroccolo deleted the add-extended-line-strings branch July 15, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants