Skip to content

Conversation

gbroccolo
Copy link
Collaborator

The PR contains the definitions of the extended geometries for Polygon type. As made for the previous extended geometries, basics methods for the new types have been defined to reduce the extradimensions to 2D objects in order to be integrated with the rest of the repo.

NOTE: Additional Line types have been defined to complain the AsSegment method of the extended Polygons in order to obtain segments of 3D, 2D+1D and 3D+1D points.

@gbroccolo gbroccolo requested a review from gdey February 22, 2021 23:08
@gbroccolo gbroccolo self-assigned this Feb 22, 2021
@coveralls
Copy link

coveralls commented Feb 22, 2021

Pull Request Test Coverage Report for Build 511

  • 179 of 213 (84.04%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 56.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
polygonm.go 25 29 86.21%
polygonms.go 26 30 86.67%
polygons.go 26 30 86.67%
polygonz.go 25 29 86.21%
polygonzm.go 25 29 86.21%
polygonzms.go 26 30 86.67%
polygonzs.go 26 30 86.67%
line.go 0 6 0.0%
Totals Coverage Status
Change from base Build 499: 0.6%
Covered Lines: 6637
Relevant Lines: 11813

💛 - Coveralls

@gbroccolo gbroccolo force-pushed the add-polygon-extended-types branch from c75afe6 to 42a73c3 Compare February 23, 2021 00:05
@gbroccolo gbroccolo force-pushed the add-polygon-extended-types branch from 42a73c3 to 1ee7ee4 Compare February 23, 2021 00:42
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdey gdey merged commit 1ee7ee4 into go-spatial:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants