[compare] Consolidated Comparison functions #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported that one of our comparison functions was using math.NaN incorrectly. Turns out this comparison function was a duplicate of another function that was doing the comparison correctly, and had tests. Removed the duplicate function, and references to it were ported to the correct function. fixes #115
Pull Request Test Coverage Report for Build 517
💛 - Coveralls |
|
There are two breaking changing IsNil, and IsEmptyGeo went from bool, error to just bool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that one of our comparison functions was using math.NaN incorrectly. Turns out this comparison function was a duplicate of
another function that was doing the comparison correctly, and had tests. Removed the duplicate function, and references to it were ported to
the correct function.
fixes #115