Skip to content

Replace [4]float return value from Extenter.Extent() w/ Extent struct. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Replace [4]float return value from Extenter.Extent() w/ Extent struct. #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

// Extenter represents an interface that returns a boundbox.
type Extenter interface {
Extent() (extent [4]float64)
Extent() (extent Extent)
}

type MinMaxer interface {
Expand Down
12 changes: 7 additions & 5 deletions cmp/cmp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@ func Float64(f1, f2, tolerance float64) bool {
func Float(f1, f2 float64) bool { return Float64(f1, f2, TOLERANCE) }

// Extent will check to see if the Extents's are the same.
func Extent(extent1, extent2 [4]float64) bool {
return Float(extent1[0], extent2[0]) && Float(extent1[1], extent2[1]) &&
Float(extent1[2], extent2[2]) && Float(extent1[3], extent2[3])
func Extent(extent1, extent2 *geom.Extent) bool {
return Float(extent1.MinX(), extent2.MinX()) &&
Float(extent1.MinY(), extent2.MinY()) &&
Float(extent1.MaxX(), extent2.MaxX()) &&
Float(extent1.MaxY(), extent2.MaxY())
}

// GeomExtent will check to see if geom.BoundingBox's are the same.
func GeomExtent(extent1, extent2 geom.Extenter) bool {
return Extent(extent1.Extent(), extent2.Extent())
func GeomExtent(extent1, extent2 *geom.Extent) bool {
return Extent(extent1, extent2)
}

func PointLess(p1, p2 [2]float64) bool {
Expand Down