Adds constrained delaunay triangulation #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Provides constrained delaunay triangulation & tests of small/simple polygons. No testing has been done with large/complex polygons. 2. This does not handle overlapping edges or vertices.
1. Haven't run any real world data through it yet, but the test cases are all passing as expected.
1. General house keeping in the constrained triangulation code.
Pull Request Test Coverage Report for Build 74
💛 - Coveralls |
gdey
requested changes
May 29, 2018
There was a problem hiding this comment.
I skimmed over the files in the triangulate directory, as they appeared to be the same as the fields in #10. The comment there would apply here as well.
Look over things, I wondering if a better package layout would be:
planer/triangulate/delaunay for the Delaunay package. and planer/triangulate/delaunay/constrained for the constrained Delaunay package?
|
|
||
| /* | ||
| locateEdgeByVertex finds a quad edge that has this vertex as Orig(). This will | ||
| not be a unique edge. |
There was a problem hiding this comment.
This should be for LocateSegment not locateEdgeByVertex
| return nil | ||
| } | ||
|
|
||
| // TriangulatePseudoPolygon |
There was a problem hiding this comment.
Should this be:
// triangulatePseudoPolygon1. Modify comments to start with function name 2. Note in comments that calling with a nil object will cause a panic.
gdey
requested changes
Jun 4, 2018
| for !done { | ||
|
|
||
| for true { | ||
| base = idt.subdiv.Connect(e, base.Sym()) |
There was a problem hiding this comment.
change this to:
for {
For infinite loops in go you don't specify the conditional value.
|
This pull request has been merge with f174354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.