Skip to content

Issue 18 - out of bound panic in polygon ring. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2018
Merged

Issue 18 - out of bound panic in polygon ring. #19

merged 2 commits into from
Aug 6, 2018

Conversation

gdey
Copy link
Member

@gdey gdey commented Aug 6, 2018

Fix out of bound panic in polygonForRing.

closes #18

gdey added 2 commits August 6, 2018 16:20
@gdey
Cleanup: removed unneeded constrained package
2d18401 
We are no longer using the columnization for makevalid; no longer
need the constrained package.
@gdey
[issue-18] Found the issue in polygonForRing
f591a27 
  * Added testcase
  * issue had to do with calculating the correct i value.

  closes #18
@coveralls
Copy link

coveralls commented Aug 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 87

  • 24 of 36 (66.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-11.1%) to 59.483%
Changes Missing Coverage Covered Lines Changed/Added Lines %
planar/makevalid/tegola/edge_triangle.go 22 34 64.71%
Files with Coverage Reduction New Missed Lines %
planar/makevalid/tegola/edge_triangle.go 2 75.85%
Totals Coverage Status
Change from base Build 81: -11.1%
Covered Lines: 1358
Relevant Lines: 2283
💛 - Coveralls

@gdey gdey changed the title Issue 18 - Out of boudn Bainc in polygon ring. Issue 18 - out of bound panic in polygon ring. Aug 6, 2018
@ARolek ARolek merged commit 62800f6 into master Aug 6, 2018
@ARolek ARolek deleted the issue_18 branch August 6, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in the edge_triangle.go.
3 participants
@gdey @coveralls @ARolek