Skip to content

Conversation

ear7h
Copy link
Contributor

@ear7h ear7h commented Aug 12, 2019

I removed tegola.Tile from the function signature. The encoding function now takes an geom.Extent that is used to represent the extent of a tile. It also takes the size of the ouput tile in pixels.

This approach makes it so the encoder does not have to worry about the geom.Geometry's SRID. The passed in geom.Extent is expected to be in the same projection as the `geom.Geometry.

Todo: I need to add a comment in PrepareGeo, I'm not sure what happens when the geometry goes outside the tile. Are geometries allowed outside of the tile?

@ear7h ear7h changed the title mvt: removing tegola artifacts and docs mvt: removing tegola artifacts and adding docs Aug 12, 2019
@ARolek
Copy link
Member

ARolek commented Aug 12, 2019

@ear7h if a geometry goes outside a tile (i.e. a point outside the tile) it will be removed by the clipping process. If the geometry covers the tile, it will consist of 4 points, one at each tile corner.

@ear7h
Copy link
Contributor Author

ear7h commented Aug 12, 2019

@ARolek okay, I'll add a note about clipping in the readme and inline docs.

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ear7h
Copy link
Contributor Author

ear7h commented Aug 12, 2019

This is good to merge

@ARolek ARolek merged commit 16fd6b0 into master Aug 12, 2019
@ARolek ARolek deleted the mvt-docs branch August 12, 2019 23:49
@coveralls
Copy link

coveralls commented Aug 14, 2019

Pull Request Test Coverage Report for Build 244

  • 7 of 14 (50.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 57.321%

Changes Missing Coverage Covered Lines Changed/Added Lines %
encoding/mvt/prepare.go 7 14 50.0%
Files with Coverage Reduction New Missed Lines %
encoding/mvt/prepare.go 16 21.43%
Totals Coverage Status
Change from base Build 239: 0.0%
Covered Lines: 5414
Relevant Lines: 9445

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants