-
-
Notifications
You must be signed in to change notification settings - Fork 38
mvt: removing tegola artifacts and adding docs #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ear7h if a geometry goes outside a tile (i.e. a point outside the tile) it will be removed by the clipping process. If the geometry covers the tile, it will consist of 4 points, one at each tile corner. |
@ARolek okay, I'll add a note about clipping in the readme and inline docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is good to merge |
Pull Request Test Coverage Report for Build 244
💛 - Coveralls |
I removed
tegola.Tile
from the function signature. The encoding function now takes angeom.Extent
that is used to represent the extent of a tile. It also takes the size of the ouput tile in pixels.This approach makes it so the encoder does not have to worry about the
geom.Geometry
's SRID. The passed ingeom.Extent
is expected to be in the same projection as the `geom.Geometry.Todo: I need to add a comment in
PrepareGeo
, I'm not sure what happens when the geometry goes outside the tile. Are geometries allowed outside of the tile?