Skip to content

Conversation

gdey
Copy link
Member

@gdey gdey commented Aug 23, 2019

fixes for geom needed for constraints

gdey added 4 commits August 23, 2019 10:33
Fixed issue in IsPointOnLine
Added PointOnLineAt
Fixed append nonrepeat logic was flipped.
@coveralls
Copy link

coveralls commented Aug 23, 2019

Pull Request Test Coverage Report for Build 275

  • 13 of 29 (44.83%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 57.338%

Changes Missing Coverage Covered Lines Changed/Added Lines %
planar/triangulate/gdey/quadedge/subdivision/subdivision.go 0 2 0.0%
encoding/mvt/feature.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
encoding/mvt/feature.go 1 38.42%
Totals Coverage Status
Change from base Build 269: 0.1%
Covered Lines: 5446
Relevant Lines: 9498

💛 - Coveralls

@gdey
Copy link
Member Author

gdey commented Aug 23, 2019

Travis CGO_ENABLED=0 is failing because it is unable to get github.com/mattn/go-sqlite3 as a dependency. I don't know of a way to prevent it from getting this dependency. Which is only needed when cgo is enabled.

@gdey gdey merged commit 03aebec into master Aug 23, 2019
@gdey gdey deleted the fixes_for_geom branch August 23, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants