Skip to content

Conversation

ear7h
Copy link
Contributor

@ear7h ear7h commented Aug 29, 2019

  • added an decoder because I thought I needed it for writing geometries, turned out to be fun
    • I think the decoder needs some more tests for malformed inputs, eg. uneven parens and eof
    • the error cases were based on behavior from postgis, tested using psql -c select ST_AsBinary('POINT(0 0)'::geometry);
  • added the geometries using a shell script and the code in this repo

this would close #24 #43

@coveralls
Copy link

Pull Request Test Coverage Report for Build 282

  • 275 of 392 (70.15%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 57.846%

Changes Missing Coverage Covered Lines Changed/Added Lines %
testing/dynamic_geoms.go 3 22 13.64%
encoding/wkt/wkt_decode.go 272 370 73.51%
Totals Coverage Status
Change from base Build 276: 0.5%
Covered Lines: 5721
Relevant Lines: 9890

💛 - Coveralls

@gdey gdey merged commit 38958cb into master Sep 2, 2019
@gdey gdey deleted the testing branch September 2, 2019 15:23
@ear7h ear7h mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WKT Decoder

3 participants