-
-
Notifications
You must be signed in to change notification settings - Fork 38
testing: added build tags to large test geometries #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have not reviewed this, but just from the description, this is the wrong direction. There are already command lines params for running quick tests and the testing support for this. We should be using |
@gdey this is a really small PR, can you give it another look? I'm not quite sure if t.Skip() or t.Short() would be appropriate here. I think the main issue that @ear7h is trying to address is skipping the compiler from including these geometries unless the developer is explicitly interested in working on them. |
What are you trying to do with this PR? What is the problem you are trying to address? Adding the build tag will force any tests that is making use of these cases to include that tag as well, otherwise, things will not compile. |
@gdey The goal is what @ARolek mentioned. The files that I added the build tags to are >100MB together and compiling them takes an unnecessarily long time since the geometries end up not being used in tests. This PR is especially helpful for CI because it runs Here's the output from
|
After some discussion, we found the best solution would be to decode the geometry at runtime, storing it as a string in source code. This would prevent odd bugs from using build tags while keeping the compilation speed of tests relatively quick. I've implemented a patch on top of what's sitting in the |
a883c38
to
b1abc37
Compare
b1abc37
to
9996e12
Compare
@ear7h did you get all the package tests passing? |
* the tile geometries are now stored as a wkt string * running tests/benchmarks with the geometries is done by compiling them first * fixed bug in wkt decoder which did not process collections properly
9996e12
to
bbd865a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The changes in this pull request are actually part of #69 but I don't see that PR being merged soon (it's complicated and there's bigger fish to fry) but, I'd really like this patch so that tests can be compiled/run in a reasonable amount of time.
The only changes in this PR are build tags to the files which contain or organize tiles in the
testing
directory.