Skip to content

Conversation

gdey
Copy link
Member

@gdey gdey commented Sep 26, 2019

Initial conversion code that takes a LngLat value and transforms it into a UTM value.

@gdey gdey requested a review from ear7h September 26, 2019 17:43
Added the ability to work with UTM coordinate reference systems
@gdey gdey force-pushed the utm_conversion_functions branch from 1e0cb20 to b3a18b7 Compare September 27, 2019 20:14
@gdey gdey requested a review from ARolek September 27, 2019 23:08
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments and some leftover logs.

Copy link
Contributor

@ear7h ear7h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small documention/comment related things. Some of this stuff is really dense!

* Moved Tests to appropriate package
* Fixed spelling errors
* Improved code comments
* Added missing tests
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ear7h ear7h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and docs look good, thank you!

@gdey gdey merged commit 623c714 into master Oct 1, 2019
@gdey gdey deleted the utm_conversion_functions branch October 1, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants