Skip to content

Conversation

gdey
Copy link
Member

@gdey gdey commented Nov 13, 2019

Fixes #89

Turns out the issue had to do with winding order flipping on truncation of point durning the MVT encoding stage.

gdey added 6 commits November 13, 2019 12:35
Winding order for Points need to understand if the coordinate system is left or right handed. This allow one to encapisulate that information before passing it down the pipe.
When truncating the points to an int64 space winding order can flip, ensure the winding order are correct
@coveralls
Copy link

coveralls commented Nov 13, 2019

Pull Request Test Coverage Report for Build 430

  • 201 of 286 (70.28%) changed or added relevant lines in 15 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.6%) to 58.126%

Changes Missing Coverage Covered Lines Changed/Added Lines %
planar/triangulate/delaunay/subdivision/geom.go 0 2 0.0%
planar/makevalid/hitmap/polygon_hitmap.go 0 3 0.0%
planar/triangulate/delaunay/quadedge/topo.go 1 4 25.0%
encoding/wkt/wkt.go 0 4 0.0%
planar/triangulate/delaunay/subdivision/testdb.go 0 8 0.0%
winding/winding.go 97 110 88.18%
encoding/mvt/prepare.go 9 26 34.62%
planar/makevalid/triangulate.go 9 26 34.62%
encoding/mvt/feature.go 65 83 78.31%
Files with Coverage Reduction New Missed Lines %
encoding/mvt/prepare.go 1 22.33%
planar/makevalid/makevalid.go 1 56.79%
encoding/mvt/feature.go 3 41.89%
planar/triangulate/delaunay/quadedge/edge.go 7 75.72%
Totals Coverage Status
Change from base Build 419: 0.6%
Covered Lines: 22547
Relevant Lines: 38790

💛 - Coveralls

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about comments inline.

@gdey gdey requested a review from ear7h November 13, 2019 22:23
@gdey gdey self-assigned this Nov 13, 2019
@gdey gdey merged commit eac2f59 into master Nov 13, 2019
@gdey gdey deleted the issue_89 branch November 13, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polygon cut is appearing as an additional polygon

3 participants