Skip to content

Conversation

ear7h
Copy link
Contributor

@ear7h ear7h commented Jul 3, 2018

For my explanation, the letter "T" represents all types ("string", "bool", "int", etc.)

The error was a result of passing the []interface{} into ParseT() vs a single element from the []interface{}. Also added tests for converting from []interface{}to []T and interface{} to T

…T slices. Also refactored two errors into dict errors vs fmt.Error()
@ear7h ear7h requested review from ARolek and gdey as code owners July 3, 2018 06:45
@coveralls
Copy link

coveralls commented Jul 3, 2018

Pull Request Test Coverage Report for Build 1260

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 44.077%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/env/dict.go 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
provider/gpkg/binary_header.go 2 100.0%
Totals Coverage Status
Change from base Build 1245: 0.5%
Covered Lines: 5019
Relevant Lines: 11387

💛 - Coveralls

@ear7h
Copy link
Contributor Author

ear7h commented Jul 3, 2018

Just to mention this should close #445

@ARolek
Copy link
Member

ARolek commented Jul 3, 2018

LGTM

@ARolek ARolek merged commit 92dd008 into v0.7.0 Jul 3, 2018
@ARolek ARolek deleted the issue-445 branch July 3, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants