Skip to content

Issue 82 SSL support #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2019
Merged

Issue 82 SSL support #455

merged 1 commit into from
Oct 6, 2019

Conversation

ear7h
Copy link
Contributor

@ear7h ear7h commented Jul 9, 2018 •
edited
Loading

changes
* most config logic moved to server.New function instead of commands
* tile_buffer now property of webserver
* webserver config uses pointers to place default values

  • ssl support in webserver config
  • test for ssl support

todo
* tests for https
* push middleware
* remove globals

@ear7h ear7h requested review from ARolek and gdey as code owners July 9, 2018 23:20
@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1807

  • 10 of 29 (34.48%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 44.754%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/server.go 10 18 55.56%
cmd/tegola/cmd/server.go 0 11 0.0%
Totals Coverage Status
Change from base Build 1787: -0.8%
Covered Lines: 24989
Relevant Lines: 55836
💛 - Coveralls

@ARolek ARolek changed the base branch from v0.7.0 to v0.8.x August 10, 2018 22:38
@ARolek ARolek changed the base branch from v0.8.x to 0.9.x November 2, 2018 04:18
@ARolek ARolek closed this Nov 2, 2018
@ARolek ARolek changed the base branch from 0.9.x to v0.9.0 November 2, 2018 04:25
@ARolek ARolek reopened this Nov 2, 2018
@ARolek ARolek closed this Nov 6, 2018
@ARolek ARolek changed the base branch from v0.9.0 to v0.9.x November 6, 2018 18:27
@ARolek ARolek reopened this Nov 6, 2018
@ARolek ARolek changed the base branch from v0.9.x to v0.10.x April 9, 2019 21:39
@ear7h ear7h changed the base branch from v0.10.x to v0.11.x September 25, 2019 19:34
@ear7h ear7h force-pushed the issue-82 branch 4 times, most recently from 0eec3c6 to 3e75ad8 Compare September 26, 2019 19:12
@ear7h ear7h changed the title [WIP] Issue 82 SSL support and H2 push Issue 82 SSL support Sep 26, 2019
ARolek
ARolek approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ARolek
Copy link
Member

ARolek commented Oct 6, 2019

The new config params need to be add to the tegola.io documentation once v0.11.x is released.

@ARolek ARolek merged commit b248cb0 into v0.11.x Oct 6, 2019
@ARolek ARolek deleted the issue-82 branch October 6, 2019 03:51
@ARolek ARolek mentioned this pull request Mar 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

@gdey gdey Awaiting requested review from gdey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ear7h @coveralls @ARolek