Skip to content

Issue 468 #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 4, 2018
Merged

Issue 468 #503

merged 5 commits into from
Sep 4, 2018

Conversation

ARolek
Copy link
Member

@ARolek ARolek commented Sep 4, 2018

No description provided.

olt and others added 3 commits July 31, 2018 09:03
@olt
provider/postgis: replace Mapnik pixel_width/height and scale_denomin…
115d13e 
…ator SQL tokens
@ARolek
Merge branch 'mapnik-sql-tokens' of https://github.com/olt/tegola int…
68932dc 
…o olt-mapnik-sql-tokens
@ARolek
mapnik token compatibility #468
c0d42ff 
- added uppercaseTokens func to support case insensitive tokens
within ! bangs. mapnik uses lowercase tokens (i.e. !pixel_width!)
and tegola uses upper case tokens (i.e. !PIXEL_WIDTH!). this allows
for either to work.
@ARolek ARolek requested a review from gdey September 4, 2018 21:32
gdey
gdey reviewed Sep 4, 2018
View reviewed changes
provider/postgis/util.go
for i := range rs {
if rs[i] == '!' {
uppercase = !uppercase
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have a continue

gdey
gdey requested changes Sep 4, 2018
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes. But Looks good other wise.

gdey
gdey approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1382

  • 30 of 32 (93.75%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 44.251%
Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/postgis/util.go 27 29 93.1%
Files with Coverage Reduction New Missed Lines %
cmd/tegola/cmd/cache.go 12 27.07%
Totals Coverage Status
Change from base Build 1368: 0.1%
Covered Lines: 5172
Relevant Lines: 11688
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1386

  • 30 of 32 (93.75%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 44.208%
Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/postgis/util.go 27 29 93.1%
Files with Coverage Reduction New Missed Lines %
provider/gpkg/binary_header.go 2 100.0%
cmd/tegola/cmd/cache.go 5 25.19%
Totals Coverage Status
Change from base Build 1368: 0.09%
Covered Lines: 5167
Relevant Lines: 11688
💛 - Coveralls

@ARolek ARolek added this to the v0.8.0 milestone Sep 4, 2018
@ARolek ARolek merged commit 7359abc into v0.8.x Sep 4, 2018
@ARolek ARolek deleted the issue-468 branch September 4, 2018 22:33
@ARolek ARolek mentioned this pull request Sep 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdey gdey gdey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ARolek @coveralls @gdey @olt