Skip to content

Conversation

ARolek
Copy link
Member

@ARolek ARolek commented Apr 5, 2019

Added a check to the result set field descripters of TileFeatures
to ensure the configured geom_fieldname is present. This catches
a misconfiguration error that may arise at runtime.

closes #590

Added a check to the result set field descripters of TileFeatures
to ensure the configured geom_fieldname is present. This catches
a misconfiguration error that may arise at runtime.

closes #590
@ARolek ARolek requested a review from gdey as a code owner April 5, 2019 04:13
@coveralls
Copy link

coveralls commented Apr 5, 2019

Pull Request Test Coverage Report for Build 1575

  • 16 of 20 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 45.236%

Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/postgis/util.go 4 5 80.0%
provider/postgis/error.go 0 3 0.0%
Totals Coverage Status
Change from base Build 1572: 0.07%
Covered Lines: 5522
Relevant Lines: 12207

💛 - Coveralls

Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ARolek ARolek merged commit f9d84ff into v0.9.x Apr 5, 2019
ARolek added a commit that referenced this pull request Apr 9, 2019
Added a check to the result set field descripters of TileFeatures
to ensure the configured geom_fieldname is present. This catches
a misconfiguration error that may arise at runtime.

closes #590
@ARolek ARolek deleted the issue-590 branch April 9, 2019 21:34
ARolek added a commit that referenced this pull request Apr 9, 2019
Added a check to the result set field descripters of TileFeatures
to ensure the configured geom_fieldname is present. This catches
a misconfiguration error that may arise at runtime.

closes #590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants