Skip to content

GitHub Actions migration for Push and Pull Request events #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

GitHub Actions migration for Push and Pull Request events #675

merged 1 commit into from
Mar 23, 2020

Conversation

ARolek
Copy link
Member

@ARolek ARolek commented Mar 22, 2020

  • Setup Go testing matrix for versions 1.11, 1.12 and 1.13.
  • Setup Postgres service and associated testing.
  • Setup Redis service and associated testing.
  • Setup AWS S3 testing.
  • Setup Coverals test coverage reporting.
  • Removed old Travis CI on push testing.
  • Removed no longer used CI scripts.

@ARolek ARolek requested review from gdey and ear7h March 22, 2020 00:12
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5f41f7c8a-PR-675

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 53 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 44.86%
Files with Coverage Reduction New Missed Lines %
cache/s3/s3.go 53 50.24%
Totals Coverage Status
Change from base Build 1986: -0.4%
Covered Lines: 5498
Relevant Lines: 12256
💛 - Coveralls

gdey
gdey approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Much nicer

@ARolek
GitHub Actions migration for Push and Pull request
60eae11 
* Setup Go testing matrix for versions 1.11, 1.12 and 1.13.
* Setup Postgres service and associated testing.
* Setup Redis service and associated testing.
* Setup AWS S3 testing.
* Setup Coverals test coverage reporting.
* Removed old Travis CI on push testing.
* Removed no longer used CI scripts.
* Bumped go build versions to 1.12, 1.13, 1.14
ear7h
ear7h reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@ear7h ear7h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why is the .travis.yml still needed?

@ARolek
Copy link
Member Author

ARolek commented Mar 23, 2020

@ear7h I'm not done with the migration for release building. working on that now.

@ARolek ARolek merged commit 4e867d1 into master Mar 23, 2020
@ARolek ARolek deleted the gh-actions branch March 23, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ear7h ear7h ear7h left review comments

@gdey gdey gdey approved these changes

+1 more reviewer

@pnorman pnorman pnorman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ARolek @gdey @pnorman @ear7h