Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OK packets representing EOF #805

Open
julienschmidt opened this issue May 23, 2018 · 2 comments
Open

Support for OK packets representing EOF #805

julienschmidt opened this issue May 23, 2018 · 2 comments
Milestone

Comments

@julienschmidt
Copy link
Member

EOF packets are deprecated. MySQL servers 5.7.5 and up instead send OK packets that signal an EOF, if the client advertises support: https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_ok_packet.html

@marti1125
Copy link

Hi, I am interesting in contribute with this. Could you tell me more? how to I can get start?

@methane
Copy link
Member

methane commented Sep 17, 2019

@marti1125 There is a pull request (#962) for fixing this. So you can get started by:

  1. Understand MySQL protocol by reading documents and packets (using Wireshark).
  2. Review and test WIP: Add support for OK packets representing EOF #962.

@julienschmidt julienschmidt modified the milestones: v1.5.0, v1.6.0 Sep 30, 2019
tz70s pushed a commit to tz70s/mysql that referenced this issue Sep 5, 2020
tz70s pushed a commit to tz70s/mysql that referenced this issue Sep 5, 2020
@julienschmidt julienschmidt modified the milestones: v1.6.0, v1.7.0 Apr 1, 2021
@methane methane modified the milestones: v1.7.0, v1.8.0 May 2, 2023
@methane methane modified the milestones: v1.8.0, v1.9.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants