Timezone fix #117
Merged
Timezone fix #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you adapt the test for the current git master, please? |
|
Sorry, forget the last part. You want a different DSN every time |
|
Hah, should be fixed now. I have no idea how I ended starting from a commit that old (I just checked out the code yesterday). |
|
LGTM now. Also, include this change in #118 |
|
LGTM |
julienschmidt
added a commit
that referenced
this pull request
Sep 2, 2013
[FIX] Timezone fix Convert to DB timezone when inserting time.Time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix -- Convert to DB timezone when inserting time.Time objects. Previous code would serialize time in the object's time zone, not the DB connection's time zone. See regression test for details.
Also, fixed cosmetic bug with CONCURRENT tests.