Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Is comparison on MySQLError #1210



Copy link

@chriskirkland chriskirkland commented May 14, 2021


Adds support for comparison of MySQLError instances with errors.Is. This useful for comparing errors (either client-side or server-side) in application code, particularly for things like circuit breakers and retriers.


  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Copy link

It sounds good.
Please fix the tests with Go 1.12 by adding // +build go113.

We can drop support Go 1.12 because the latest version of Go is 1.16.
But this change may be not an enough reason to do it.

Copy link

methane commented May 15, 2021

We can drop support Go 1.12 because the latest version of Go is 1.16.
But this change may be not an enough reason to do it.

I think we should drop old versions support now, because we just released v1.6.

@shogo82148 shogo82148 mentioned this pull request May 15, 2021
5 tasks
Copy link

I dropped support of Go 1.12. #1211

Copy link
Contributor Author

@methane @shogo82148 looks like the PR checks are failing because of a decrease in coverage because of newly "uncovered" lines in rows.go which this PR doesn't touch. Any suggestions how I can work around that?

errors_test.go Outdated Show resolved Hide resolved
Copy link

@julienschmidt julienschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@julienschmidt julienschmidt modified the milestones: v1.6.0, v1.7.0 Jun 3, 2021
@julienschmidt julienschmidt merged commit 417641a into go-sql-driver:master Jun 3, 2021
andygrunwald added a commit to andygrunwald/mysql that referenced this pull request Jul 31, 2021
* master: (93 commits)
  return unsigned in database type name when necessary (go-sql-driver#1238)
  add an invalid DSN test case (go-sql-driver#1235)
  refactoring (*textRows).readRow in a more clear way (go-sql-driver#1230)
  use utf8mb4 instead of utf8 in TestCharset (go-sql-driver#1228)
  improve readability follows go-staticcheck (go-sql-driver#1227)
  support Is comparison on MySQLError (go-sql-driver#1210)
  Wording correction in README (go-sql-driver#1218)
  noCopy implements sync.Locker (go-sql-driver#1216)
  Fix readme: MaxIdle is same or less than MaxOpen (go-sql-driver#1215)
  Drop support of Go 1.12 (go-sql-driver#1211)
  Release v1.6.0 (go-sql-driver#1197)
  add Go 1.16 to the build matrix (go-sql-driver#1198)
  Implement driver.Validator interface (go-sql-driver#1174)
  handling decoding pem error (go-sql-driver#1192)
  stop rounding times (go-sql-driver#1172)
  improve GitHub Actions workflows (go-sql-driver#1190)
  Move tests from Travis to Actions (go-sql-driver#1183)
  Fix go vet error (go-sql-driver#1173)
  README: Make usage code more friendly (go-sql-driver#1170)
  Fix a broken link to cleartext client side plugin (go-sql-driver#1165)
@chriskirkland chriskirkland deleted the feature/mysqlerror-is branch February 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants