move benchmarks to own file #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arnehormann
commented
Sep 15, 2013
arnehormann
commented
- move benchmarks from driver_test.go into its own file
- add benchmarks written by Brad Fitzpatrick to measure allocations
| } | ||
|
|
||
| // Workaround to get Go 1.0 compatibility for Travis-CI | ||
| type AllocReporter interface { |
There was a problem hiding this comment.
current master is Go 1.1+ only
|
PTAL |
| ) | ||
|
|
||
| func initRoundtripBenchmarks() ([]byte, int, int) { | ||
| roundtripOnce.Do(func() { |
There was a problem hiding this comment.
Why don't you use a == nil check as before?
There was a problem hiding this comment.
Because benchmarks could run concurrently and this is the only safe way to guard it... I think. I don't know, though. It's a new PR with old code. Should I change it to == nil?
There was a problem hiding this comment.
I'm pretty sure benchmarks don't run concurrently if not explicitly marked with http://golang.org/pkg/testing/#T.Parallel
ghost
assigned
|
PTAL |
|
LGTM |
arnehormann
added a commit
that referenced
this pull request
Sep 15, 2013
move benchmarks to own file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.