Add an Exec Benchmark #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very useful for profiling and comparing to Query
| remain := int64(b.N) | ||
| var wg sync.WaitGroup | ||
| wg.Add(concurrencyLevel) | ||
| defer wg.Wait() |
There was a problem hiding this comment.
I'd like you to drop the defer and move wg.Wait() below the loop - but that's not a blocker.
... Besides, it reads and feels very weird to use atomic.AddInt64 and sync.WaitGroup (which uses AddInt32 internally) here, but I can't think of a better way right now (and probably ever)...
There was a problem hiding this comment.
I'll change this in a later commit maybe
|
LGTM (with or without my suggested change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have no plans to include a complete set of Benchmarks (yet), but this particular one was extremley useful for profiling and comparing to Query.