Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct maxAllowedPacket default value mentioned in docs to match the… #1412

Merged
merged 1 commit into from Apr 15, 2023
Merged

Correct maxAllowedPacket default value mentioned in docs to match the… #1412

merged 1 commit into from Apr 15, 2023

Conversation

sjmudd
Copy link
Contributor

@sjmudd sjmudd commented Apr 14, 2023

Description

Fix a minor change in the docs where the size of the new maxAllowedPacket size was not updated to match the code change.

Checklist

  • Code compiles correctly - no change in code
  • Created tests which fail without the change (if possible) - no change in tests
  • All tests passing - N/A
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file - already present

@sjmudd
Copy link
Contributor Author

sjmudd commented Apr 14, 2023 •
edited

Related to: #1355, #1411

shogo82148
shogo82148 approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit faedeff into go-sql-driver:master Apr 15, 2023
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjmudd @shogo82148