optimized the execution flow of the TestRowsColumnTypes unit test #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems just hiding real problem. I don't think it is good idea. |
methane
reviewed
May 4, 2023
driver_test.go
Outdated
| continue | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Put this code here:
if t.Failed() {
return
}There was a problem hiding this comment.
like this code？
I tested it and the code does seem more appropriate.
for i := range values {
if types[i] == nil {
t.Failed()
return
}
values[i] = reflect.New(types[i]).Interface()
}
There was a problem hiding this comment.
No. Just put my code here.
I think types[i] == nil happens only when test is already failed.
There was a problem hiding this comment.
agree.
I will resubmit a pull request.
methane
reviewed
May 4, 2023
driver_test.go
Outdated
| for i := range values { | ||
| if types[i] == nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This doesn't make sense at all. Remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
When running the TestRowsColumnTypes unit test on OceanBase, I encountered a panic and the test progress was forced to exit.
Adding this defensive strategy can prevent the occurrence of panic issues and thus prevent blocking the execution of the unit test.
Checklist