Skip to content

Conversation

zhenjl
Copy link

@zhenjl zhenjl commented Dec 13, 2013

No description provided.

@julienschmidt
Copy link
Member

LGTM

julienschmidt added a commit that referenced this pull request Dec 14, 2013
updated comments for second part of the password cipher
@julienschmidt julienschmidt merged commit 54ff48d into go-sql-driver:master Dec 14, 2013
@julienschmidt
Copy link
Member

Oops, you forgot to add yourself to the AUTHORS file. Please give us the details to add

@zhenjl
Copy link
Author

zhenjl commented Dec 14, 2013

@julienschmidt didn't think fixing a comment is worthy of AUTHORship .. but you can use

Jian Zhen

thx

@julienschmidt
Copy link
Member

We don't distinguish between coding and non-coding contributions like documentation. We are grateful for every contribution 😉

Which eMail-address would you like us to add?

@zhenjl
Copy link
Author

zhenjl commented Dec 14, 2013

zhenjl at gmail

guess my angle brackets in prev comment got killed

thx

julienschmidt added a commit that referenced this pull request Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants