Skip to content

[shaping] expose ComputeBidiOrdering #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[shaping] expose ComputeBidiOrdering #201

wants to merge 1 commit into from

Conversation

benoitkugler
Copy link
Contributor

This PR expose the logic used to compute visual ordering for mixed LRT/RTL text.

It could be used to fix #199 in the render package.

It also includes a very small change so that it could also be used for vertical text (comparing Progression instead of Direction).

@benoitkugler benoitkugler mentioned this pull request Sep 30, 2025
Open
andydotxyz
andydotxyz approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I am glad this could help renderer, I hope to get back to it after the next Fyne release is done.

I guess we need to figure out the CI issues before this can land?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@whereswaldon whereswaldon Awaiting requested review from whereswaldon whereswaldon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong rendering for mixed LTR/RTL text
2 participants
@benoitkugler @andydotxyz