Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(workers): flags for new filters #517

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

Examples:

vela get workers  # returns all workers

vela get workers --active true  # returns active workers

vela get workers --active true --since 15m  # returns active workers that have checked in since 15 minutes ago

vela get workers --since 2020-03-20T12:00:00 # returns all workers that have checked in since the pandemic

I didn't find any sort of "fallback" option in urfave/cli to make the parseUnix bit any prettier, but I thought that would be convenient. Very similar to docker logs <container> --since <duration OR timestamp>

@ecrupper ecrupper requested a review from a team as a code owner January 11, 2024 15:09
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (1a00c3b) 85.78% compared to head (4b5c051) 85.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   85.78%   85.68%   -0.11%     
==========================================
  Files         147      147              
  Lines        6425     6476      +51     
==========================================
+ Hits         5512     5549      +37     
- Misses        754      764      +10     
- Partials      159      163       +4     
Files Coverage Δ
action/worker/get.go 93.47% <100.00%> (+0.97%) ⬆️
action/worker/update.go 100.00% <100.00%> (ø)
command/worker/update.go 75.75% <37.50%> (-12.71%) ⬇️
command/worker/get.go 75.40% <77.50%> (+1.49%) ⬆️

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@ecrupper ecrupper merged commit d23ab1a into main Jan 15, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the enhance/workers/list-filters branch January 15, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants