Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): use NewEventsFromSlice function to handle both secrets and repo AllowEvents #543

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

ecrupper
Copy link
Contributor

Previously only repo had support for AllowEvents. But with go-vela/types#366, we can add support for both repo and secrets pretty easily.

@ecrupper ecrupper requested a review from a team as a code owner March 21, 2024 14:47
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.00%. Comparing base (379fce6) to head (d4b662b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   82.09%   82.00%   -0.09%     
==========================================
  Files         147      147              
  Lines        3635     3584      -51     
==========================================
- Hits         2984     2939      -45     
+ Misses        480      474       -6     
  Partials      171      171              
Files Coverage Δ
action/repo/add.go 94.28% <100.00%> (+3.17%) ⬆️
action/repo/update.go 100.00% <100.00%> (ø)
action/secret/add.go 83.33% <100.00%> (+0.47%) ⬆️
action/secret/update.go 83.33% <100.00%> (+0.47%) ⬆️
command/repo/add.go 93.10% <ø> (ø)
command/repo/update.go 93.10% <ø> (ø)
command/secret/add.go 75.00% <ø> (ø)
command/secret/update.go 75.00% <ø> (ø)

@ecrupper ecrupper merged commit 408fbfb into main Mar 21, 2024
15 of 17 checks passed
@ecrupper ecrupper deleted the fix/secret-events branch March 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants