Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add administration and installation docs #259

Merged
merged 42 commits into from
Dec 22, 2021
Merged

Conversation

jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Nov 24, 2021

@jbrockopp jbrockopp added the feature Indicates a new feature label Nov 24, 2021
@jbrockopp jbrockopp self-assigned this Nov 24, 2021
Copy link
Collaborator

@JordanSussman JordanSussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial feedback

content/administration/_index.md Outdated Show resolved Hide resolved
content/administration/server/_index.md Outdated Show resolved Hide resolved
content/administration/server/compiler.md Outdated Show resolved Hide resolved
content/administration/server/compiler.md Outdated Show resolved Hide resolved
content/administration/server/compiler.md Outdated Show resolved Hide resolved
content/administration/server/_index.md Outdated Show resolved Hide resolved
content/administration/server/_index.md Outdated Show resolved Hide resolved
content/administration/server/compiler.md Outdated Show resolved Hide resolved
content/administration/server/compiler.md Outdated Show resolved Hide resolved
content/administration/worker/_index.md Outdated Show resolved Hide resolved
@jbrockopp
Copy link
Contributor Author

jbrockopp commented Dec 2, 2021

@jonathonlacher thanks for reviewing and appreciate the feedback 🎉

For context, here are some of the sites being used for inspiration with this content:

but my main feedback is that I think there needs to be greater differentiation between the different types of documentation. For background, a while ago I found this explanation of the 4 types of documentation: tutorials, how-to guides, reference, and explanation.

Thanks for the link! Do you by chance have a doc site you are aware of that embodies this approach?

I ask because I would like to see a real-world example of this approach in action as I'm struggling to understand it.

To be more specific, most tutorials I've seen on doc sites contain content relating to the tutorial with the how-to-guide embedded in the tutorial. I would be confused for a tutorial to skip providing the tasks required to complete the learning.

Also, the tutorials I've had the greatest experiences with provide explanative information along the way to augment the experience and enhance the learning as you're going through the steps to complete the tutorial.

I find it very difficult to drive the differentiation between a tutorial and a how-to guide so hoping an example would help.

Here are some examples to help illustrate what I mean where it seems the tutorial and how-to-guide are synonymous:

You do have an explicit reference section of the docsite, and then under the Administration section, the server, worker, and UI each have their own reference section.

Ok so thinking how to digest this feedback and take action.. would it be better to move the reference docs for each service under administration to the global reference section?

Also the Administrative section in total a mixture of explanation, reference, and how-to. I haven't given much thought to alternative documentation layouts, but as someone less familiar with the inner workings of Vela it's not intuitively obvious which documentation section will have the info I'm looking for.

Do you think it would help if we added more information to the administrative and reference sections?

Maybe adding details that help distinguish what content can be found in these sections?

Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the env var docs, it would be nice to make required vs optional much more apparent at a glance.

Plus a variety of other comments.

content/administration/server/reference/_index.md Outdated Show resolved Hide resolved
content/administration/server/reference/_index.md Outdated Show resolved Hide resolved
content/administration/server/reference/_index.md Outdated Show resolved Hide resolved
content/administration/ui/reference/_index.md Show resolved Hide resolved
@jbrockopp
Copy link
Contributor Author

jbrockopp commented Dec 3, 2021

For the env var docs, it would be nice to make required vs optional much more apparent at a glance.

Plus a variety of other comments.

@cognifloyd thanks for reviewing and appreciate the feedback 🎉

thoughts on how to accomplish this (required vs optional)?

Would making this bold for each variable be enough?

@cognifloyd
Copy link
Member

thoughts on how to accomplish this (required vs optional)?
Would making this bold for each variable be enough?

Yeah, I think bold should be enough. Maybe a future version can adjust the formatting even more, but bold should be good enough for now.

@wass3r
Copy link
Collaborator

wass3r commented Dec 4, 2021

but my main feedback is that I think there needs to be greater differentiation between the different types of documentation. For background, a while ago I found this explanation of the 4 types of documentation: tutorials, how-to guides, reference, and explanation.

Thanks for the link! Do you by chance have a doc site you are aware of that embodies this approach?

i have brought up this document before as well. The site has a "Who's using this?" section here: https://documentation.divio.com/adoption/

it might make sense to open a new issue for that - it does feel a bit beyond the scope of this PR as it may affect the whole doc site?

it would also be nice to add an explicit self-contained tutorial for setting up the whole system.

potentially, this might be are more direct action item. @jonathonlacher, what approach did you envision here though? aws, heroku, gcp, etc? or just locally? docker compose? or something else?

@JordanSussman
Copy link
Collaborator

May take a little while to complete the outstanding feedback since @jbrockopp is on vacation until next week.

@jbrockopp
Copy link
Contributor Author

but my main feedback is that I think there needs to be greater differentiation between the different types of documentation. For background, a while ago I found this explanation of the 4 types of documentation: tutorials, how-to guides, reference, and explanation.

Thanks for the link! Do you by chance have a doc site you are aware of that embodies this approach?

i have brought up this document before as well. The site has a "Who's using this?" section here: https://documentation.divio.com/adoption/

it might make sense to open a new issue for that - it does feel a bit beyond the scope of this PR as it may affect the whole doc site?

Agreed 😅

It sounds like we should open one or more issues to try and address reformatting for the entire site

cognifloyd
cognifloyd previously approved these changes Dec 13, 2021
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for a docs MVP.

@jbrockopp
Copy link
Contributor Author

@cognifloyd FYI - made some changes based off internal feedback on the reference pages with all the variables

JordanSussman
JordanSussman previously approved these changes Dec 13, 2021
@cognifloyd
Copy link
Member

That's much nicer!

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbrockopp jbrockopp merged commit 27bd9aa into master Dec 22, 2021
@jbrockopp jbrockopp deleted the feat/administration branch December 22, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started add install documentation
7 participants