-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add administration and installation docs #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial feedback
@jonathonlacher thanks for reviewing and appreciate the feedback 🎉 For context, here are some of the sites being used for inspiration with this content:
Thanks for the link! Do you by chance have a doc site you are aware of that embodies this approach? I ask because I would like to see a real-world example of this approach in action as I'm struggling to understand it. To be more specific, most tutorials I've seen on doc sites contain content relating to the tutorial with the how-to-guide embedded in the tutorial. I would be confused for a tutorial to skip providing the tasks required to complete the learning. Also, the tutorials I've had the greatest experiences with provide explanative information along the way to augment the experience and enhance the learning as you're going through the steps to complete the tutorial. I find it very difficult to drive the differentiation between a tutorial and a how-to guide so hoping an example would help. Here are some examples to help illustrate what I mean where it seems the tutorial and how-to-guide are synonymous:
Ok so thinking how to digest this feedback and take action.. would it be better to move the reference docs for each service under administration to the global reference section?
Do you think it would help if we added more information to the administrative and reference sections? Maybe adding details that help distinguish what content can be found in these sections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the env var docs, it would be nice to make required vs optional much more apparent at a glance.
Plus a variety of other comments.
@cognifloyd thanks for reviewing and appreciate the feedback 🎉 thoughts on how to accomplish this ( Would making this bold for each variable be enough? |
Yeah, I think bold should be enough. Maybe a future version can adjust the formatting even more, but bold should be good enough for now. |
i have brought up this document before as well. The site has a "Who's using this?" section here: https://documentation.divio.com/adoption/ it might make sense to open a new issue for that - it does feel a bit beyond the scope of this PR as it may affect the whole doc site?
potentially, this might be are more direct action item. @jonathonlacher, what approach did you envision here though? aws, heroku, gcp, etc? or just locally? docker compose? or something else? |
May take a little while to complete the outstanding feedback since @jbrockopp is on vacation until next week. |
Agreed 😅 It sounds like we should open one or more issues to try and address reformatting for the entire site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for a docs MVP.
@cognifloyd FYI - made some changes based off internal feedback on the reference pages with all the variables |
That's much nicer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes go-vela/community#4
closes #250
This adds administration and installation documentation for Vela.
Here are some of the sites used for inspiration with this content:
There is a lot of new pages and lines of code added with this change.
Due to this, I've created a fork to improve the experience when reviewing the content:
https://jbrockopp.github.io/docs/administration/
A quick link to the documentation for each service: