Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(admin): remove get-all functions #192

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

ecrupper
Copy link
Contributor

Related to: go-vela/server#734

Remove these functions, as they will now return 404.

@ecrupper ecrupper requested a review from a team as a code owner November 15, 2022 17:45
@ecrupper ecrupper self-assigned this Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #192 (edac60c) into main (1a21cb8) will increase coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   89.79%   90.68%   +0.89%     
==========================================
  Files          18       18              
  Lines        1440     1320     -120     
==========================================
- Hits         1293     1197      -96     
+ Misses        107       91      -16     
+ Partials       40       32       -8     
Impacted Files Coverage Δ
vela/admin.go 97.05% <ø> (+9.22%) ⬆️

@ecrupper ecrupper merged commit 6b73754 into main Nov 15, 2022
@ecrupper ecrupper deleted the enhance-remove-admin-get-all branch November 15, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants