Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant error message #222

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Apr 14, 2023

removing the redundant messaging around status code registration errors, in favor of the cli messaging in the open pull request: https://github.com/go-vela/cli/pull/430/files#diff-394d0fca556d973a6a57311dd6b477989da6b48fbe1ff6f8caf8dc7d8f6fd39dR36

removing the redundant messaging around status code registration errors, in favor of the cli messaging in the open pull request:
https://github.com/go-vela/cli/pull/430/files#diff-394d0fca556d973a6a57311dd6b477989da6b48fbe1ff6f8caf8dc7d8f6fd39dR36
@plyr4 plyr4 requested a review from a team as a code owner April 14, 2023 14:36
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #222 (d95d814) into main (9f72cb2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          18       18           
  Lines        1386     1386           
=======================================
  Hits         1266     1266           
  Misses         88       88           
  Partials       32       32           
Impacted Files Coverage Δ
vela/admin.go 95.71% <0.00%> (ø)

@plyr4 plyr4 merged commit c423fde into main Apr 17, 2023
@plyr4 plyr4 deleted the chore/redundant-register-err branch April 17, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants