fix(vault): parse pre-v0.23 vault secrets #1086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a vault secret has not been updated since before
v0.23
, it will not haveallow_events
orallow_substitution
. We can infer these values by converting event slice into the allow events mask and by setting substitution setting to the same setting as the command setting.I didn't include any update process on the Vela side. Fortunately the UI submits the entire secret form on update, so users will slowly update their vault secrets on their own accord.
We could also consider creating a migration script of sorts to prevent this code, but we're also supporting v1 and v2 of Vault in code as well. Not saying that's an excuse, but perhaps revisiting our backwards compatibility in general could be a good future issue 🤷