Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go): specific go version #1101

Merged
merged 3 commits into from
Apr 11, 2024
Merged

chore(go): specific go version #1101

merged 3 commits into from
Apr 11, 2024

Conversation

@wass3rw3rk wass3rw3rk requested a review from a team as a code owner April 9, 2024 15:27
@wass3rw3rk wass3rw3rk marked this pull request as draft April 9, 2024 15:29
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.47%. Comparing base (1058d96) to head (afdb190).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files         370      370           
  Lines       11788    11788           
=======================================
  Hits         7600     7600           
  Misses       3671     3671           
  Partials      517      517           

@wass3rw3rk
Copy link
Member Author

wass3rw3rk commented Apr 10, 2024

looks like the issue is related to go fix ./... .. see https://go-review.googlesource.com/c/go/+/527342 and it has not made its way into any of the releases yet: https://go.dev/doc/devel/release#go1.21.0 checking the release milestones for releases after feb 22.

there is a bug with "go fix". a fix has been pushed but not yet
released. temporarily disabling "go fix" in validate action.

ref:
golang/go@7fd62ba
@wass3rw3rk wass3rw3rk merged commit 4fea679 into main Apr 11, 2024
11 of 13 checks passed
@wass3rw3rk wass3rw3rk deleted the chore/specific-go-version branch April 11, 2024 14:02
wass3rw3rk added a commit to go-vela/types that referenced this pull request Apr 11, 2024
wass3rw3rk added a commit to go-vela/types that referenced this pull request Apr 11, 2024
wass3rw3rk added a commit to go-vela/cli that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants