Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): move deployment logic to separate package #847

Merged
merged 3 commits into from
May 17, 2023

Conversation

ecrupper
Copy link
Contributor

Based off of #615 #754 #809 #828 and #829

This change continues the refactor efforts initially introduced in the above PR.

This adds a new deployment package to the github.com/go-vela/server/api package.

This contains all the same handlers that existed previously but with each of them within their own file.

I also updated a few of the previous packages in this refactor effort to have a doc.go file.

@ecrupper ecrupper self-assigned this May 17, 2023
@ecrupper ecrupper requested a review from a team as a code owner May 17, 2023 18:23
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #847 (777ede7) into main (3aa414e) will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
+ Coverage   58.43%   59.02%   +0.59%     
==========================================
  Files         270      269       -1     
  Lines       15636    15479     -157     
==========================================
  Hits         9137     9137              
+ Misses       6075     5918     -157     
  Partials      424      424              

plyr4
plyr4 previously approved these changes May 17, 2023
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit - some copy pasta that already existed before this PR.

Comment on lines 40 to 41
// name: deployment
// description: Name of the org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// name: deployment
// description: Name of the org
// name: deployment
// description: Number of the deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants