-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): move deployment logic to separate package #847
Conversation
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 58.43% 59.02% +0.59%
==========================================
Files 270 269 -1
Lines 15636 15479 -157
==========================================
Hits 9137 9137
+ Misses 6075 5918 -157
Partials 424 424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit - some copy pasta that already existed before this PR.
api/deployment/get.go
Outdated
// name: deployment | ||
// description: Name of the org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// name: deployment | |
// description: Name of the org | |
// name: deployment | |
// description: Number of the deployment |
Based off of #615 #754 #809 #828 and #829
This change continues the refactor efforts initially introduced in the above PR.
This adds a new
deployment
package to thegithub.com/go-vela/server/api
package.This contains all the same handlers that existed previously but with each of them within their own file.
I also updated a few of the previous packages in this refactor effort to have a
doc.go
file.