feat(api/admin): add endpoint to clean pending / running builds #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #863 +/- ##
==========================================
+ Coverage 66.13% 66.26% +0.13%
==========================================
Files 297 300 +3
Lines 13876 13930 +54
==========================================
+ Hits 9177 9231 +54
Misses 4252 4252
Partials 447 447
|
wass3rw3rk
reviewed
May 26, 2023
cognifloyd
reviewed
May 27, 2023
cognifloyd
reviewed
May 30, 2023
|
|
||
| // ensure the mock expects the name query | ||
| _mock.ExpectExec(`UPDATE "builds" SET "status"=$1,"error"=$2,"finished"=$3,"deploy_payload"=$4 WHERE created < $5 AND (status = 'running' OR status = 'pending')`). | ||
| WithArgs("error", "msg", time.Now().UTC().Unix(), AnyArgument{}, 3). |
There was a problem hiding this comment.
Is this going to create a flaky test? Because timestamp is calculated both in the test and in the code under test.
Ditto for the step and service clean tests.
There was a problem hiding this comment.
It would if we were comparing the objects, but all we do is check the count in the test
wass3rw3rk
approved these changes
May 30, 2023
cognifloyd
approved these changes
May 30, 2023
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oftentimes during upgrades, network blips, or failures in worker-server communication, builds, steps, and or services, never make it out of
pendingorrunningstates. This endpoint gives platform admins the power to clean build resources that have been pending or running for longer than a specified time as well as give the builds a specified error message.