Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(database): return pipeline on created and updated #882

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

ecrupper
Copy link
Contributor

Continuing efforts from: #861

All uses of CreatePipeline and UpdatePipeline involve calling GetPipelineForRepo immediately afterwards. This change cuts that second DB call from the flow.

@ecrupper ecrupper self-assigned this Jun 12, 2023
@ecrupper ecrupper requested a review from a team as a code owner June 12, 2023 17:16
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d51b1c3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage        ?   71.31%           
=======================================
  Files           ?      303           
  Lines           ?    12366           
  Branches        ?        0           
=======================================
  Hits            ?     8819           
  Misses          ?     3117           
  Partials        ?      430           

database/pipeline/create.go Show resolved Hide resolved
@ecrupper ecrupper requested a review from cognifloyd June 13, 2023 15:01
@ecrupper ecrupper dismissed cognifloyd’s stale review June 13, 2023 16:39

addressed feedback

@ecrupper ecrupper merged commit ca3e1e3 into main Jun 13, 2023
@ecrupper ecrupper deleted the refactor-return-db-pipeline branch June 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants