Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add context to Users #941

Merged
merged 4 commits into from
Sep 1, 2023
Merged

enhance: add context to Users #941

merged 4 commits into from
Sep 1, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 28, 2023

continuing the efforts started in #898 #922 #923 #930 #937 #938 #940

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner August 28, 2023 15:21
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@38fae72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage        ?   70.92%           
=======================================
  Files           ?      311           
  Lines           ?    12895           
  Branches        ?        0           
=======================================
  Hits            ?     9146           
  Misses          ?     3284           
  Partials        ?      465           

@wass3r
Copy link
Collaborator

wass3r commented Aug 30, 2023

conflicts :(

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 91e26c4 into main Sep 1, 2023
12 of 13 checks passed
@plyr4 plyr4 deleted the enhance/ctx-user branch September 1, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants