Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable setting ulimits for services #190

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Conversation

meinenec
Copy link
Contributor

@meinenec meinenec commented Jul 21, 2021

completes go-vela/community/issues/267

pkg-runtime already has the ability to set ulimits for steps, this PR enables the compiler to set ulimits for services.

@meinenec meinenec requested a review from a team as a code owner July 21, 2021 19:38
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #190 (fba9bfe) into master (4c255a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   97.09%   97.10%           
=======================================
  Files          53       53           
  Lines        5448     5449    +1     
=======================================
+ Hits         5290     5291    +1     
  Misses        112      112           
  Partials       46       46           
Impacted Files Coverage Δ
yaml/service.go 90.00% <100.00%> (+0.16%) ⬆️

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meinenec meinenec merged commit b8d37ac into master Jul 22, 2021
@meinenec meinenec deleted the feat/ulimit_services branch July 22, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants